httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: chunking confusion
Date Fri, 18 Aug 2000 04:47:51 GMT

> 1) don't put the trailing "0\r\n\r\n" in lenstr; that buffer is
>    already in use (pointed to by another transient bucket); using
>    lenstr again overlays that other chunk header
> 2) insert the bucket with the trailing "0\r\n\r\n" *before* the eos bucket

You're right about both of these.  Whoops.  :-)  I'll commit this
immediately, because this patch looks correct to me.

Ryan

> Unfortunately, I still haven't seen eos come through the chunking
> filter when I test with a simple CGI...  I'll have to look into that a
> bit further...  Does anybody already know the answer?
> <         apr_snprintf(lenstr, 6, "0\r\n\r\n");
> <         dptr = ap_bucket_transient_create(lenstr, 5, &tempint);
> <         ap_brigade_append_buckets(b, dptr);
> ---
> >         dptr = ap_bucket_transient_create("0\r\n\r\n", 5, &tempint);
> >         /* insert before the eos bucket */
> >         b->tail->prev->next = dptr;
> >         dptr->prev = b->tail->prev;
> >         b->tail->prev = dptr;
> >         dptr->next = b->tail;
> 2961d2963
> <         
> 
> 
> -- 
> Jeff Trawick | trawick@ibm.net | PGP public key at web site:
>      http://www.geocities.com/SiliconValley/Park/9289/
>           Born in Roswell... married an alien...
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message