httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/main http_core.c
Date Wed, 16 Aug 2000 19:33:30 GMT

Is there a reason just using a LIFO stack won't work?  I have given it
quite a bit of thought, and it seems to work.  I haven't come up with a
case where it doesn't work, and it is cleaner and easier to understand
than having five or six kinds of filters.

Ryan

On Wed, 16 Aug 2000, Greg Stein wrote:

> When we first outlined this stuff, we had a whole bunch of filter types. In
> my register/add_filter stuff, I coalesced them to two types. This was based
> on using the ordering of the insert_filters hook to get them inserted in a
> reasonable order.
> 
> Since we cannot actually depend on the hook ordering now for this change,
> then the proper solution is to re-introduce some of the filter types that we
> had envisioned earlier in the process.
> 
> Specifically, I would recommend adding AP_FTYPE_NETWORK and making the CORE
> filter have that type. Thus, if we add filters as N1, F1, C1, and F2, we get
> a final chain of F1, F2, C1, N1.
> 
> Cheers,
> -g
> 
> On Wed, Aug 16, 2000 at 12:15:38PM -0700, rbb@covalent.net wrote:
> > 
> > This doesn't solve anything.  As per my last e-mail, this only works when
> > all filters are inserted via insert_filters hooks.  Since that isn't true,
> > and we have never said it would be true, this doesn't solve anything.
> > 
> > On 16 Aug 2000 gstein@locus.apache.org wrote:
> > 
> > > gstein      00/08/16 12:03:28
> > > 
> > >   Modified:    src/main http_core.c
> > >   Log:
> > >   fix the insertion of the CORE filter. it should be happen last.
> > >   
> > 
> > 
> > _______________________________________________________________________________
> > Ryan Bloom                        	rbb@apache.org
> > 406 29th St.
> > San Francisco, CA 94131
> > -------------------------------------------------------------------------------
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message