httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manoj Kasichainula <ma...@io.com>
Subject Re: [PATCH] ap_add_filter
Date Mon, 21 Aug 2000 01:01:31 GMT
On Sun, Aug 20, 2000 at 07:25:48PM -0400, Rodent of Unusual Size wrote:
> NO transformation filters should EVER be added without the
> knowledge and permission of a person.  Failure to comply
> with that virtually guarantees violations of the Principle
> of Least Astonishment.

Well, I do think it's perfectly reasonable for PHP to decide to filter
it's own output. (assuming the PHP developers ever decide to do this;
I hope it's clear we're using PHP as a hypothetical example.) If we
don't allow filter Q to run it's own output through other arbitrary
filters, then the Q developers will just end up duplicating the code
in their own module. I think we can agree that's a bad thing.

Now, OTOH, I do agree that PHP shouldn't be able to cause other
modules' output to be filtered. (get ready...) One nice thing about my
filtering proposal (the 2.0 one in this case) is that PHP can
construct its own arbitrary filter chain, but because it is contained
in the PHP structure, data that doesnt go through PHP won't go through
PHP's filter chain either. When the PHP filter is deleted, its
filter chain is never seen again.

With the current scheme, AFAIK, there has to be a cleanup registered
on ap_add_filter, so that when PHP is deleted from the filter chain,
the filters it added also get deleted. Now, these filters also need to
be kept track of in some way so that the deletion can be done
reliably.


Mime
View raw message