httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Reid" <dr...@jetnet.co.uk>
Subject Re: [PATCH] ap_bucket_* read() has wrong type in definitions
Date Thu, 24 Aug 2000 09:14:07 GMT
Ermmmm


> Read is defined as taking a size_t, not an ssize_t. We could possibly lose
> data from an iovec, where iov_len is size_t, but we were trying to stuff
> it into a apr_ssize_t.
>

...

> Index: src/ap/ap_buckets_eos.c
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/ap/ap_buckets_eos.c,v
> retrieving revision 1.5
> diff -u -r1.5 ap_buckets_eos.c
> --- ap_buckets_eos.c 2000/08/19 06:04:51 1.5
> +++ ap_buckets_eos.c 2000/08/23 17:52:51
> @@ -57,7 +57,7 @@
>  #include <stdlib.h>
>
>  static apr_status_t eos_read(ap_bucket *b, const char **str,
> -                                apr_ssize_t *len, int block)
> +                                apr_size_t *len, int block)
>  {
>      *str = NULL;
>      *len = AP_END_OF_BRIGADE;

Guess the plus and minus should be reversed given your opening statement?

david


Mime
View raw message