Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 82489 invoked by uid 500); 25 Jul 2000 21:07:20 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 82473 invoked from network); 25 Jul 2000 21:07:20 -0000 X-Authentication-Warning: koj.rkbloom.net: rbb owned process doing -bs Date: Tue, 25 Jul 2000 14:08:14 -0700 (PDT) From: rbb@covalent.net X-Sender: rbb@koj.rkbloom.net To: new-httpd@apache.org Subject: Re: Patch for winnt MPM ?? In-Reply-To: <397E01B6.C73EEE0C@level8.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N Gregory, This looks good to me. I'll try to commit this later today. If I don't get to it until tomorrow, don't worry, I will commit it. Ryan On Tue, 25 Jul 2000, Gregory Nicholls wrote: > Hi, > A couple of the files in the winnt mpm (registry.c and service.c) are using > APR_NOTFOUND to indicate missing files. I _think_ they should be using APR_ENOFILE. > My code base has APR_NOTFOUND listed as a missing socket in a poll set. > Now bearing in mind that I've _never_ used CVS before today I've prepared what > I _think_ is a patch for registry.c. If no one dies laughing I'll try service.c as > well. > G. > > > --------------------------------- cut here > -------------------------------------------- > Index: registry.c > =================================================================== > RCS file: /home/cvspublic/apache-2.0/src/modules/mpm/winnt/registry.c,v > retrieving revision 1.24 > diff -b -B -r1.24 registry.c > 184c184 > < * The return value is APR_SUCCESS, APR_ENOPATH, APR_NOTFOUND, or the OS error > --- > > * The return value is APR_SUCCESS, APR_ENOPATH, APR_ENOFILE, or the OS error > 228c228 > < rv = APR_NOTFOUND; > --- > > rv = APR_ENOFILE; > 268c268 > < rv = APR_NOTFOUND; > --- > > rv = APR_ENOFILE; > > _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------