Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 77928 invoked by uid 500); 8 Jul 2000 16:08:42 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 77909 invoked from network); 8 Jul 2000 16:08:33 -0000 X-Authentication-Warning: koj.rkbloom.net: rbb owned process doing -bs Date: Sat, 8 Jul 2000 09:08:47 -0700 (PDT) From: rbb@covalent.net X-Sender: rbb@koj.rkbloom.net To: new-httpd@apache.org Subject: Re: Encoding code in APR In-Reply-To: <20000707230610.A9278@innovation.ch> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII > > Either apr/crypto or apr/hash, either way. crypto is probably better, > > because it can't be confused with hash tables. > > Ok, so > > apr_md5, apr_sha1 -> lib/apr/crypto/ Yes. > ap_base64, ap_checkpass -> lib/utils/ ap_base64 should be moved. ap_checkpass still bothers me. The function it implements is in APR already. I would rather just see that function moved into the crypt directory in APR. > ap/ap_cache, ap/ap_hooks -> lib/utils/ > > I'm wondering about main/util_* - util_md5.c and util_date.c could be > moved to lib/utils/, but the other stuff references things like request_rec > and therefore aren't suitable for putting in lib/utils/ unless we make that > lib tightly bound to apache (i.e. unusable outside of it). Take a VERY close look at main/utils_*. For the most part, the references to request_rec's can be replaced with one or two fields from the request_rec. Regardless, I am VERY hesitant to move anything into lib/utils right now. That library will need it's own build system, because we don't want to tie it to Apache. The hooks are tied to APR VERY tightly, I haven't looked at ap_cache. I say go for it. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------