Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Thu, 13 Jul 2000 01:34:04 -0700
From: Greg Stein <gstein@lyra.org>
To: new-httpd@apache.org
Subject: Re: [PATCH] config tree fixups
Message-ID: <20000713013404.V29590@lyra.org>
Mail-Followup-To: new-httpd@apache.org
References: <396D33D6.246008F9@covalent.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <396D33D6.246008F9@covalent.net>;
 from rmorgan@Covalent.NET on Wed, Jul 12, 2000 at 08:13:26PM -0700

On Wed, Jul 12, 2000 at 08:13:26PM -0700, Ryan Morgan wrote:
> 
> The following patch adds a global variable that allows modules to find
> the root of the configuration tree.  This very helpful to modules like
> mod_info, since they can now look in the tree for configuration
> directives rather than reparse the entire configuration file.
>...
> --- include/http_config.h	2000/06/03 16:27:03	1.29
> +++ include/http_config.h	2000/07/13 02:07:34
> @@ -366,6 +366,7 @@
>  #ifdef CORE_PRIVATE
>  
>  extern API_VAR_EXPORT module *top_module;
> +extern API_VAR_EXPORT ap_directive_t *conftree;
>  
>  extern API_VAR_EXPORT module *ap_prelinked_modules[];
>  extern API_VAR_EXPORT module *ap_preloaded_modules[];

That name should be namespace protected, and it shouldn't occur within the
CORE_PRIVATE area. I would suggest "ap_config_tree" for a name.

That might trim back the size of your patch (although creating more
semantically-close-to-their-purpose names such as "sub_tree" is a Good
Thing)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/