httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Woolley" <>
Subject Re: [PATCH] buckets: make API a little cleaner
Date Sat, 22 Jul 2000 03:23:08 GMT
>>> 07/21/00 11:11PM >>>

>I am against this patch.  It just adds a layer that is unnecessary, and
>is going to be taken out by the compiler anyway.  I also dislike name
>changes like this one.

As I mentioned, my initial inclination (and actually the first patch I
created which I then didn't submit) was to delete the other two wrapper
functions like the two I added in this patch (ap_get_bucket_char_str()
and ap_get_bucket_len()), and just have all of the bucket functions be
accessed via the function pointers.  That was because I knew you don't
like the wrapper functions.  =-)

But the function pointers just got to seem cumbersome, especially since
you have to pass the object back to itself (eg, b->insert(b,...)).

These macros sound very interesting... I'll look forward to seeing them.


View raw message