httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] Filter registration.
Date Tue, 25 Jul 2000 03:38:51 GMT

> I see your point. However, a placeholder type for a bucket isn't quite
> "enough" as I'd rather see a signature that looks like:
> 
> API_EXPORT(ap_status_t) ap_pass_brigade(ap_filter_t *filter,
>                                         ap_bucket_brigade *bucket)
> 
> Specifically: the ap_filter_t contains the request_rec that the filter was
> inserted on. This is important if you chain together filters from multiple
> (sub)requests. The change in filter->r is the signal for the partitioning of
> filters between (sub)requests.
> 
> Roy seems to argue that ->r shouldn't be present anywhere in there. I think
> that position is too idealistic, so I'm not listening to it :-)  No,
> seriously, if we *can* get to a point where the request_rec isn't needed in
> a filter, then it will be easier to remove the sucker from the structure
> than from the signatures. [because (theoretically) nobody is referring to
> ->r any more]
> 
> But as I mentioned in the other note, we can simply tweak these typedefs and
> signatures with our specific "filter system" patches.

BTW, I should point out that ap_filter_t does not contain a request_rec
right now.  :-)

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message