httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/lib/apr/threadproc/win32 thread.c threadpriv.c
Date Sat, 08 Jul 2000 16:11:14 GMT
> >   -    if (lock == NULL) {
> >   -        return APR_ENOFILE;
> >   -    }
> >   +    /* ### this is broken. is the signature broken? */
> >        thelock = &(lock->mutex);
> >        return APR_SUCCESS;
> >    }
> 
> There were a number of ap_get_os_* functions like the above which I marked.
> I wasn't sure whether the signature was correct and we needed to say
> something like *thelock = lock->mutex, or whether the signature should be
> ap_os_lock_t **thelock and the line would read *thelock = &lock->mutex.
> 
> Can somebody who knows this code a bit better take a look?

I'll look at this sometime this weekend.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message