httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/main iol_socket.c
Date Thu, 06 Jul 2000 22:01:37 GMT

> > I would prefer to not have this discussion for the third time right
> > now.  We have gone over this stuff over and over and over again.  Feature
> > macros have been decided upon and implemented.  The only platform that
> > this doesn't work for is Windows, and we have a solution for Windows.
> 
> no no no... the link-time error is fine.
> 
> I was referring to the run-time platforms. If you're calling ap_sendfile()
> on Win32 and the function discovers that the feature isn't there, then why
> is it a Bad Thing to simulate it? In other words, it seems fine to test the
> feature macro, decide to use ap_sendfile() and just have it work -- not
> worry about the APR_ENOTIMPL coming back. (sure, other errors could)


> > > (arguably, you could torch APR_HAS_SENDFILE and just pretend that it always
> > >  exists... I'm not sure where that would fall down)

I was responding to this comment.  We can't just torch APR_HAS_SENDFILE
for the reasons I've stated.

As far as simulating it on non-2000/NT platforms.  I see no reason not to
do it.

Ryan


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message