httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/main iol_socket.c
Date Thu, 06 Jul 2000 20:55:46 GMT

> > I did write a log for this.  ARGH!  Basically, we can't just assume APR is
> > providing ap_sendfile.  Setting the sendfile pointer to ap_sendfile is
> > only valid if APR_HAS_SENDFILE is true.
> 
> I don't understand this, then. The #if/#endif below assumes that
> iol_sendfile *was* set and arrived at that function. *then* it switches on
> the behavior.
> 
> Wouldn't you want to put the #if down in the socket_methods structure?

Yes.  I feel stupid.  :-)

Fix on the way.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message