httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] revised, final filtering patch. (ready for review)
Date Sun, 02 Jul 2000 01:02:09 GMT
On Sat, 1 Jul 2000, Greg Stein wrote:

> This is a revision of my patch to incorporate feedback from Roy, Ryan, and
> Dirk.
> 
> Specifically, Dirk has an outstanding veto caused by the "char* handler"
> from my previous posted patch. This has been removed in this patch, so I
> would hope that Dirk likewise removes his veto.
> 
> Other changes in this patch:

I have made only the briefest of scans over this patch, and I will do a
more thorough review either tomorrow or Monday.  On my very first review,
one point still bothers me.  This patch still uses pools to allocate the
memory for the data.  This means that all of the memory is allocated for
the lifetime of the request.

I realize that this patch only implements the string-like buckets, but
if a module uses these buckets at all, then that memory will stick around
through the life of the request.  This means even if we flush out to the
disk, the memory is around.

I really think we need to avoid pools when we do filtering.  See the
beginnings of the bucket implementation that I posted earlier today.

Ryan



Mime
View raw message