httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <>
Subject Re: [PATCH] mod_file_cache - memory leak
Date Thu, 06 Jul 2000 15:19:16 GMT wrote:

> On Wed, 5 Jul 2000, Greg Ames wrote:
> > The mmapfile function in mod_file_cache has the same pool usage problem as the mmapfile
> > function in mod_mmap_static.  Also take care of a warning under Win32.
> I thought these were going to be combined at some point.  They serve
> basically the same function.
> Ryan

Yeah, they are being combined, but mod_file_cache isn't quite ready for prime time on Unix.
I've got another patch for SEGVs ready to go after this patch is committed.  I'm trying to
be a good doobie and separate my patches into easily reviewable, discrete units :-) but that
really slows down the process when this mod need a bunch of fixes.

btw, the cast for Win32 is not needed - CreateFile takes a const char * filename.


View raw message