httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/modules/mpm/winnt mpm_winnt.c registry.c service.c
Date Tue, 25 Jul 2000 03:20:37 GMT
Oh. *VERY* important meta-point.

I didn't review this patch much at all when it first came through. I
thought, "adding apr_strings.h headers? simple enough. [scan scan] yah,
looks like that is all that is happening in there."

But no... you had other changes embedded in there. As a result, they were
committed without any effective opportunity for somebody to review them.

Can we say "split the patches!" 100 times fast? :-)

Go watch Teletubbies for an hour for penance.

Cheers,
-g

On Mon, Jul 24, 2000 at 08:18:05PM -0700, Greg Stein wrote:
> On Mon, Jul 24, 2000 at 08:28:13PM -0500, William A. Rowe, Jr. wrote:
> >...
> > >   --- mod_so.c	2000/07/15 01:07:42	1.22
> > >   +++ mod_so.c	2000/07/25 00:58:20	1.23
> > >   @@ -257,7 +258,7 @@
> > >    
> > >            return ap_pstrcat(cmd->pool, "Cannot load ", szModuleFile,
> > >    			  " into server: ",
> > >   -			  ap_dso_error(modhandle, my_error, sizeof(my_error)),
> > >   +			  ap_strerror(status, my_error, sizeof(my_error)),
> > >    			  NULL);
> > >        }
> > 
> > Sorry, a quick fix.  Is this reasonable or should I retract it?
> 
> Retract it. DSO error strings are always constructed with ap_dso_error().
> 
> >...
> > >   --- mod_auth_digest.c	2000/06/24 17:34:02	1.20
> > >   +++ mod_auth_digest.c	2000/07/25 00:58:20	1.21
> > >   @@ -498,7 +499,7 @@
> > >    static const char *set_qop(cmd_parms *cmd, void *config, const char *op)
> > >    {
> > >        digest_config_rec *conf = (digest_config_rec *) config;
> > >   -    const char **tmp;
> > >   +    char **tmp;
> > >        int cnt;
> > 
> > Was causing constness errors, as I recall, but it can be retracted.
> 
> This is a correct change. tmp[] is modified in that function.
> 
> Cheers,
> -g
> 
> -- 
> Greg Stein, http://www.lyra.org/

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message