httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@ibm.net>
Subject Re: [PATCH] Compile fixes in mod_mmap_static
Date Tue, 18 Jul 2000 03:23:54 GMT
> Date: Wed, 12 Jul 2000 14:39:22 -0400 (EDT)
> From: "Victor J. Orlikowski" <v.j.orlikowski@gte.net>
> 
> Fixes minor bugs (unneeded semi, and a differing type).
> 
> 
> Index: src/modules/experimental/mod_mmap_static.c
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/modules/experimental/mod_mmap_static.c,v
> retrieving revision 1.17
> diff -u -r1.17 mod_mmap_static.c
> --- mod_mmap_static.c	2000/07/05 19:13:58	1.17
> +++ mod_mmap_static.c	2000/07/12 18:33:47
> @@ -312,7 +312,7 @@
>  	    ap_send_mmap (match->mm, r, 0, match->finfo.size);
>  	}
>  	else {
> -	    long length;
> +	    unsigned long length;
>  	    ap_off_t offset;
>  	    while (ap_each_byterange(r, &offset, &length)) {
>  		ap_send_mmap(match->mm, r, offset, length);

Let's see...  Third parm to ap_each_byterange() is ap_size_t *; fourth
parm to ap_send_mmap() is size_t.  Instead of changing length to
unsigned long, consider changing length to ap_size_t.  Perhaps
ap_send_mmap() should be tweaked as well (to use the APR type).

OTOH, mod_mmap_static should go away soon, right?  9 days ago (or so),
Greg Ames was about to get the mod_mmap_static-type support in
mod_file_cache working IIRC.


-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message