httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] mod_file_cache - use iol_sendfile directly
Date Tue, 18 Jul 2000 04:22:38 GMT
On Mon, Jul 17, 2000 at 09:04:20PM -0700, rbb@covalent.net wrote:
> 
> > So... -1 on direct use of iol_sendfile in *any* Apache module.
> > 
> > To enforce that, I'd even be up for making the client IOL private (with
> > caveats on how SSL support interacts with / replaces the IOL).
> 
> If the filtering is done correctly, even if the client IOL is private, SSL
> can be introduced without ANY core changes.  If that isn't the case, then
> filtering isn't done correctly.  The only caveat to that, is that the SSL
> module MAY have to write a new iol type.  Although, I believe that with
> some function pointer magic, even this could be avoided completely.

SSL may need to be implemented as an IOL rather than a filter. As I
understand it from a prior discussion, the SSL library directly wraps the
socket descriptors.

So... since we can't abstract away the socket descriptors in the SSL
library, it must be on the very bottom of the output stack.

Hmm. I guess it would be possible to organize the output (in some future
pass) as something like:

  generator -> filters -> buffer-filter -> IOL-filter

or:
  generator -> filters -> buffer-filter -> SSL-filter

The former would be for IOL-based SSL support. The latter could just toss
the IOL concept and go straight to the SSL library.


In any case, the original point was that modules should never use iol_* to
try to deliver content to the client. I would even say that they should not
touch connection->client at all (some modules do this today).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message