httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] APRize sdbm
Date Thu, 13 Jul 2000 10:20:56 GMT
On Wed, Jul 12, 2000 at 01:13:55PM +0100, Joe Orton wrote:
> This patch does:
> 
> * General cleanup of interface: add namespace protection, make struct
> SDBM internal, add ap_status_t return types.
> * Use APR file IO.
> * Assign copyright to ASF (it was public domain) and add license.

I've applied this patch. The next one is coming up in a bit...

> I've tried to keep out whitespace changes, but I'd like to submit
> another patch to bring the sdbm code into Apache-standard formatting so
> this code is easier to maintain.

That would be cool. You can do this manually, or try GNU indent. See the
.indent.pro file in mod_dav for the Apache style settings. I can't seem to
find a copy in the 2.0 repository...

There are a lot of things that could be done to SDBM :-) ... it is very old
code. I could name a half dozen things right off the bat. But go ahead and
take your shot! :-)

[ and you're doing a great job of chunking your patches into clean sets! ]

> Apologies that the diff is pretty unclear for the first few chunks,
> since the changes are so drastic, but it gets better...

Not a problem. I moved the three new functions to the bottom of the file. It
cleared up the diff very quickly, and made it much easier to review. You'll
see that in the commit email.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message