httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/threadproc/win32 thread.c threadpriv.c
Date Sat, 08 Jul 2000 11:39:56 GMT
On Sat, Jul 08, 2000 at 11:31:50AM -0000, gstein@locus.apache.org wrote:
>...
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/locks/win32/locks.c,v
>...
>    ap_status_t ap_get_os_lock(ap_os_lock_t *thelock, ap_lock_t *lock)
>    {
>   -    if (lock == NULL) {
>   -        return APR_ENOFILE;
>   -    }
>   +    /* ### this is broken. is the signature broken? */
>        thelock = &(lock->mutex);
>        return APR_SUCCESS;
>    }

There were a number of ap_get_os_* functions like the above which I marked.
I wasn't sure whether the signature was correct and we needed to say
something like *thelock = lock->mutex, or whether the signature should be
ap_os_lock_t **thelock and the line would read *thelock = &lock->mutex.

Can somebody who knows this code a bit better take a look?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message