httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] mod_dav: APRize fs/repos.c
Date Thu, 06 Jul 2000 12:10:09 GMT
On Thu, Jul 06, 2000 at 02:39:44AM +0100, Joe Orton wrote:
> Patch attempt two attached, which differs from the previous in
> initializing ap_file_t's to 0.
> 
> Incremental to that, below is a forward-port of the "maintain executable
> bit" fix from mod_dav 1.0.

This patch is excellent, as always :-). I basically dropped it right in,
with a few extra mods noted below.

I've got the original and incremental patches applied, but locus is barfing
right now. I can't get the stuff checked in.

Note: I didn't pick up the ap_ssize_t change in the stream API. Those
functiosn will never returned signed data, so there isn't any reason to use
those variables types. (and yes: APR doesn't either, so its type probably
ought to change also)

I also APR-ized lock.c and added ap_rename_file().

Just waiting for locus...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message