httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject RE: [PATCH] Filter registration.
Date Tue, 25 Jul 2000 01:18:16 GMT
to both Greg and Ryan:

> From: Greg Stein []
> Sent: Monday, July 24, 2000 7:53 PM
> On Mon, Jul 24, 2000 at 05:44:21PM -0700, Greg Stein wrote:
> > On Mon, Jul 24, 2000 at 05:25:01PM -0700, wrote:
> > > 
> > > The two files I am including here do nothing but filter
> > > registration.  This is a combination of Greg's patch and 
> my patch for
> > > filter registration only!   I can't stress that enough.  :-)
> > 
> > :-)
> This is actually a very cool patch and it allows us to begin 
> to do some "real" work with the filtering code.
> In a word: Coolness

You have -no- idea how glad we new-httpd-watchers are for you two to
have worked out a patch that you can both accept :-)

I know you have both looked to the list for significant feedback on
your respective designs, and we are happy to oblige.  Seeing that you
both feel you -need- specific issues handled by filtering, though,
you two are absolutely in the best position to argue the merits and
come to a common perspective (not to slight Dean, Roy, or other key
architects of Apache!!!)  But when you two can dovetail into an
acceptable solution, we have the battle won :-)

I've tried to follow, and accidently committed some new mod_isapi
code (does very little yet), and intend to write the ISAPI 5.0 spec.

Until we have an existing demand for filters (a well defined and very
commonly used API), we can't see how they do/don't suit us.  And I got
lost in the debate (agreed we need a bucket with a length, and never a
strlen'ed char*, etc... but those are the simple questions.)

So I'll be patching up the bit of mod_isapi code I broke and introduce
the filtering.  Forewarned lurkers:  an ISAPI filter isn't what we are
thinking of as filters (although they are a part of the parcel.)  ISAPI
filters include such things as header rewrites, redirections, etc, that
don't actually use 'filtering'.

Good luck to you both in solving this code, and ++1 to the patch.


View raw message