Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 51076 invoked by uid 500); 10 Jun 2000 17:08:51 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 51061 invoked from network); 10 Jun 2000 17:08:50 -0000 X-Authentication-Warning: koj.rkbloom.net: rbb owned process doing -bs Date: Sat, 10 Jun 2000 10:08:38 -0700 (PDT) From: rbb@covalent.net X-Sender: rbb@koj.rkbloom.net To: new-httpd@apache.org Subject: Re: cvs commit: apache-2.0/src/os/win32 os.h In-Reply-To: <20000610095804.D16880@lyra.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N > > +#if APR_FILE_BASED_SHM > > +#define USE_FILE_BASED_SCOREBOARD > > +#else > > +#define USE_MEM_BASED_SCOREBOARD > > +#endif > > + > > #if defined(CHARSET_EBCDIC) && !defined(APACHE_XLATE) > > #define APACHE_XLATE > > #endif > > Would this be better in src/include/mpm_common.h? I just put these in the same place as we have always defined the USE_.*SCOREBOARD. We could change them, but this information isn't really defined by the MPM, it is just used by them. I don't really have a strong feeling about this one way or the other. > And shouldn't we namespace-protect these symbols? They've never been namespace-protected before. :-) I guess we probably should. I wasn't really thinking about that when I wrote the code. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------