Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 43925 invoked by uid 500); 1 Jun 2000 22:18:48 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 43914 invoked from network); 1 Jun 2000 22:18:47 -0000 Date: Thu, 1 Jun 2000 15:18:54 -0700 (PDT) From: Greg Stein To: new-httpd@apache.org Subject: Re: cvs commit: apache-2.0/src/modules/standard mod_auth_digest.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N On Thu, 1 Jun 2000 rbb@covalent.net wrote: >... > > Heh. Then I'm confused :-) > > > > I'd say that APR should stub the things, much like it stubs the XLATE > > stuff. > > > > Well... whatever. :-) Basic point is that the stubs for ap_shm_* in > > mod_auth_digest are ugly and a different solution ought to be found. > > Actually, the XLATE stuff should be changed to match the rest of APR. :-) > > How do you feel about having MPMs which don't need shared memory > re-implementing ap_shm_* with malloc/free? Icky. The problem is when somebody goes to read the code. They will see ap_shm_ calls in there, and get thrown off on what is really happening. The MPM is, more than likely, going to need to make changes other than a simple malloc/free substitution. I'd rather see the SHM (or not) decision grouped up within the MPM, rather than stub some with ap_shm_* plus some other bits. Kind of hard to explain here... :-) Cheers, -g -- Greg Stein, http://www.lyra.org/