Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Sun, 25 Jun 2000 21:48:15 -0700
From: Greg Stein <gstein@lyra.org>
To: new-httpd@apache.org
Subject: Re: [PATCH] un-const-ify ap_socket_t parms to allow optimizations
Message-ID: <20000625214815.N29590@lyra.org>
Mail-Followup-To: new-httpd@apache.org
References: <200006260239.WAA01381@k5.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <200006260239.WAA01381@k5.localdomain>;
 from trawick@ibm.net on Sun, Jun 25, 2000 at 10:39:48PM -0400

On Sun, Jun 25, 2000 at 10:39:48PM -0400, Jeff Trawick wrote:
> Currently, the ap_socket_t parm is "const ap_socket_t *" in most cases
> where it would be allowed by the current code.
> 
> Certain optimizations (like deferring a call to getsockname() until it
> is really needed) require that the ap_socket_t parameter be modified
> in most any situation.  This patch removes const from all applicable
> ap_socket_t parameters.  I prefer this change to lying about it (i.e.,
> using a cast).
> 
> Comments, concerns?

Seems reasonable to me.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/