httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] link-based filtering
Date Mon, 26 Jun 2000 21:09:04 GMT

> > > > and most of buff.c can be
> > > > removed and replaced by modules.  Plus, mod_ssl becomes simplistic.  
> > > 
> > > I suspect either patch set will allow this.
> > 
> > You're patch relies on Buff to do the layering.
> 
> I get the feeling that you didn't really look at it, then. This is certainly
> not the case. There are no BUFF objects in the filtering code.
> 
> At the bottom of the chain, just like today, the BUFF exists.

I have reviewed the patch, and no there are no BUFF's in there.  I was
also going by something else you said:  

<quote>
> > > It isn't mod_cgi that is going to use the iovec, it's
mod_include.  That
> > > is, unless mod_include is going to memcopy all of those into a BUFF.
> > 
> > Copying into a BUFF is what happens today, and I see no reason that it
> > wouldn't or shouldn't in the future.
</quote>

Basically, modules have to do one of two things if they are using the char
*'s.

1)  Re-implement ioblocks (because not all iovec implementations allow for
more than 16 iovecs.  At least I believe there are limitations on the
length in some implementations).

2)  Use a Buff structure to conglomerate all of the data.

Based on what you said above, it sure looks like you expect them to use a
BUFF structure.  Unless you meant that there is a BUFF at the bottom of
the chain, and within the chain they have to use iovec's or do strcpy's.

This requires multiple memcpy's.  Regardless, if they re-implement
ioblocks, they have to do multiple memcpy's, instead of the one that
Apache can do if we remove all of the char *'s.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message