httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject RE: cvs commit: apache-2.0/src/main http_log.c
Date Tue, 20 Jun 2000 21:11:42 GMT

> I believe the 'right' way, if there is one, is to handle it in
> the ap_log_error function.  One smart thing, we shouldn't be
> passing \n's to the write log entry anymore.  So, since we
> are using the ap_puts??? perhaps that's where/how we handle it,
> and just write \r\n for those platforms that have an APR_WANT_CR
> flag toggled (or have a APR_PLATFORM_ENDLINE string macro.)
> Either way you are right, recoding ap_write is wrong.

Yes, recoding ap_write is wrong.  Good to see us all agreeing.  I would
like to see an APR_ENDLINE macro I think.  This makes it VERY easy for new
programs to use APR to output valid text on all platforms.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message