httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: [PATCH] V3 of command handler patch
Date Tue, 13 Jun 2000 22:37:53 GMT

> > +0.  I love the idea, but I am grimacing at the amount the command table
> > has to change. I wish I could come up with a solution that has less of an
> > impact on module writers.
> One of the neat things about this patch is that module writers don't need to
> change *anything* ... unless they use the "maintainer mode", too.
> These changes are only visible to maintainers.

Okay, I see what I missed.  I would like to move the beginning and
trailing '{' and '}' out of the AP_INIT_(RAW_ARGS | AP_TAKE1) macros,
because I think this makes things a little bit nicer, but I won't fight
for that.  I am +1 now that my eyes have been opened.

> > BTW, I am +1 with the conversion script, because the warnings are worth
> > the change, I just want to make it an easy move for module authors.
> This would be quite nice ... even better. I like the change with or without
> the converter. Feel free :-)

I'll work on the converter this week.  This will give me a chance to test
my burgeoning PERL skills (which is always a plus).  :-)


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message