httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: cvs commit: apache-2.0/src/main http_log.c
Date Mon, 12 Jun 2000 17:45:47 GMT

> I think ap_set_default_fperms() is a misleading function name.  It
> doesn't directly set file permissions.  It actually does just the
> opposite, depending on how you look at it.  If I call
> ap_set_default_fperms(APR_UREAD|APRUWRITE|APR_GREAD|APR_GWRITE), it
> would seem that a file I then create with APR_OS_DEFAULT should be
> rw-rw----, but instead I am assured that those flags are *not* on
> because ap_set_default_fperms() passed 0660 to umask().

Yeah, you may be right about the function name.  I needed something so I
chose this.  If you hate the name, feel free to change it.

> If I look at the function name and I read your documentation, I don't
> see any mention of the umask behavior.  Also, unless on non-Unix you
> want to simulate umask behavior in setting the permissions of other
> files created via APR, I don't think setting-the-umask belongs in APR
> anyway.

Non-unix systems will need to simulate umask in this instance.  It is
absolutely important that APR has this type of feature, because it allows
us to provide some form of security.

> I'm also a little disturbed about setting the process umask, as it
> will affect everything done by the process, not just the APR file I/O
> functions. 

So maybe this needs to be in the process stuff, so that people really
understand the implications of what they are doing.  Regardless, this
feature is necessary.

> What do we really want to accomplish?  It seems that with the
> http_log.c you committed, we want to ensure that log files are only
> writable by the owner.  Maybe what we instead need is a flag like
> APR_PERM_ABSOLUTE which when passed to ap_open() along with
> permissions says that APR must do whatever it takes (including
> temporarily subverting the process's umask on Unix) to ensure that
> they are exactly as specified and not subject to any twiddling
> according to any environmental settings (e.g., umask).

I would have no problem with that.  If you like that approach more, feel
free to change it.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message