httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <grega...@raleigh.ibm.com>
Subject Re: [PATCH] htonl unresolved in http_config.c
Date Fri, 23 Jun 2000 20:03:51 GMT
rbb@covalent.net wrote:
> 
> > The htonl() in main/http_config.c wasn't being resolved on OS/390 because it requires
> > arpa/inet.h.   I believe this is due to the recent cleanup of include/ap_config.h.
 Doing
> > the #ifdef/#include in httpd_config.c works fine also, but looks kinda ugly to me
- I'd
> > rather let APR take care of platform differences when possible.
> 
> This needs to be done in http_config.c.  This is not a header that APR
> needs.  I am still working on fixing the config system so that APR can
> handle more of these.  In the meantime, let's not confuse the issues be
> making APR include things it doesn't need.
>

OK - I moved it back.  Greg
 
Index: main/http_config.c
===================================================================
RCS file: /cvs/apache/apache-2.0/src/main/http_config.c,v
retrieving revision 1.66
diff -u -d -b -w -r1.66 http_config.c
--- http_config.c	2000/06/18 13:33:29	1.66
+++ http_config.c	2000/06/23 19:58:36
@@ -76,6 +76,9 @@
 #include "ap_config.h"
 #include "apr_portable.h"
 #include "apr_file_io.h"
+#ifdef HAVE_ARPA_INET_H
+#include <arpa/inet.h>
+#endif 
 #include "httpd.h"
 #include "http_config.h"
 #include "http_core.h"

Mime
View raw message