httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/include apr.h.in apr_general.h
Date Wed, 28 Jun 2000 03:23:44 GMT
On Tue, Jun 27, 2000 at 09:35:30PM -0000, rbb@locus.apache.org wrote:
>...
>   --- apr.h.in	2000/06/11 09:08:05	1.32
>   +++ apr.h.in	2000/06/27 21:35:29	1.33
>   @@ -68,6 +68,8 @@
>    #define APR_HAVE_STRNCASECMP    @have_strncasecmp@
>    #define APR_HAVE_STRDUP         @have_strdup@
>    #define APR_HAVE_STRSTR         @have_strstr@
>   +#define APR_HAVE_MEMMOVE        @have_memmove@
>   +#define APR_HAVE_BCOPY          @have_bcopy@
>    
>    #if APR_HAVE_SYS_TYPES_H
>    #include <sys/types.h>
>   
>   
>   
>   1.37      +11 -0     apache-2.0/src/lib/apr/include/apr_general.h
>   
>   Index: apr_general.h
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr_general.h,v
>   retrieving revision 1.36
>   retrieving revision 1.37
>   diff -u -r1.36 -r1.37
>   --- apr_general.h	2000/06/18 10:58:19	1.36
>   +++ apr_general.h	2000/06/27 21:35:29	1.37
>   @@ -230,6 +230,17 @@
>    int strncasecmp(const char *a, const char *b, size_t n);
>    #endif
>    
>   +/*
>   + * String and memory functions
>   + */
>   +
>   +#if (!APR_HAVE_MEMMOVE)
>   +#define memmove(a,b,c) bcopy(b,a,c)
>   +#endif
>   +
>   +#if (!APR_HAVE_BZERO)
>   +#define bzero(a,b) memset(a,0,b)
>   +#endif

You have an APR_HAVE_BCOPY setting above, but nothing about bzero(). The
config test is also for bcopy...

If !APR_HAVE_MEMMOVE, wouldn't you also want to test for APR_HAVE_BCOPY?

And are there *any* platforms out there that don't have memmove()? I can't
possibly imagine the case, so can't we just torch that?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message