httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <>
Subject Re: [PATCH] Re: APR file i/o questions
Date Fri, 16 Jun 2000 14:43:17 GMT
On 16 Jun 2000 13:30:13 -0000, Jeff Trawick \(httpd\) wrote:

>Differences between this one and what Brian posted earlier today:
>1) this fixes a problem in where ap_open() where a lock is created for
>   non-buffered files
>2) this fixes problems setting rv correctly in the ap_read() buffered 
>   path
>3) since ap_read() works as expected, it is possible to make ap_getc()
>   and ap_fgets() even smaller
>4) ap_fgets() no longer cares about '\r'
>ap_fgets() and ap_getc() are copied in their entirety at the end as
>it is hard to piece together the little remaining code from the diff.

Ok, that looks a lot nicer. Might not be 100% the way I would have done it
but that's not necessarily a bad thing.....

 |  Brian Havard                 |  "He is not the messiah!                   |
 |  |  He's a very naughty boy!" - Life of Brian |

View raw message