httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick \(httpd\)" <traw...@ibm.net>
Subject Re: [PATCH] AIX proper diagnosis and pthread usage
Date Fri, 16 Jun 2000 01:42:46 GMT
> From: "Victor J. Orlikowski" <vjo@duke.edu>
> Date: Thu, 15 Jun 2000 19:13:46 -0400
...
> This patch fixes that, as well as adding a workaround for AIX to use
> threading in APR when compiling with gcc, since AIX has a broken
> pthread.h
...
> Index: src/lib/apr/threads.m4
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/lib/apr/threads.m4,v
> retrieving revision 1.10
> diff -u -r1.10 threads.m4
> --- threads.m4 2000/06/11 11:48:02 1.10
> +++ threads.m4 2000/06/15 23:07:29
> @@ -34,6 +34,14 @@
>    fi
>  ])dnl
> 
> +dnl Need this for silly broken AIX header files
> +AC_DEFUN(CHECK_PTHREADS_H, [
> +SAVE_FL="$CPPFLAGS"
> +CPPFLAGS="$CPPFLAGS -w"
> +AC_CHECK_HEADERS(pthread.h, [ $1 ] , [ $2 ] )
> +CPPFLAGS="$SAVE_FL"
> +])dnl
> +

This is goodness for anyone with AIX 4.3.3 (they won't have to edit
their system header file) and it shouldn't hurt anyone, other than
being an eyesore when you look at the source.  But...

I don't think you can assume that any c preprocessor will support -w,
or that -w will do what you want it to do if it isn't ignored.

As far as Google can tell me, this pthreads.h problem is limited to
AIX 4.3.3.  Why not do the standard check inside your CHECK_PTHREADS_H
and if it fails and we're AIX 4.3.3, pretend that it worked.  This
seems completely safe.  We don't have to assume anything about any
other systems.

Have fun,

Jeff
(.signature on summer recess)

Mime
View raw message