httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: cvs commit: apache-2.0/src/lib/apr/file_io/win32 readwrite.c
Date Wed, 14 Jun 2000 16:53:31 GMT
On Wed, 14 Jun 2000 12:39:22 -0400, Jeff Trawick wrote:

[...]

>I would think that you *should* be able to make it as simple as
>
>ap_status_t ap_getc(char *ch, ap_file_t *thefile)
>{
>    ap_ssize_t bread = 1;
>    return ap_read(thefile, ch, &bread);
>}
>
>However, while the Win32 ap_read() handles eof_hit, it doesn't return
>APR_EOF.  Instead, it returns the GetLastError() code (which is zero).

Exactly, and that's a whole other argument. If you dig through the archives
you should find me arguing that ap_read() _should_ return APR_EOF. However,
posix read() doesn't work this way and unixheads are the majority around
here.....

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message