httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] V3 of command handler patch
Date Tue, 13 Jun 2000 22:25:26 GMT
On Tue, Jun 13, 2000 at 03:08:51PM -0700, rbb@covalent.net wrote:
> > > This one is even less complete - but more perfect, IMO - than previous
> > > attempts. Note that I didn't use Dean's typeof() trick, coz it doesn't
> > > quite do what I want. Nor did I use the c9x syntax for unions, coz my
> > > compiler won't compile it. Nor have I done anything but the most
> > > superficial fixes for the numerous const violations (i.e., they mostly
> > > ain't fixed).
> > > 
> > > And if anyone suggests a new way of doing this, they die. Unless its
> > > better, of course. :-)
> > > 
> > > Do I commit? BTW, I'm out all day tomorrow, so expect a delay.
> > 
> > +1
> 
> +0.  I love the idea, but I am grimacing at the amount the command table
> has to change. I wish I could come up with a solution that has less of an
> impact on module writers.

One of the neat things about this patch is that module writers don't need to
change *anything* ... unless they use the "maintainer mode", too.

These changes are only visible to maintainers.

Sure, it is going to bite us, until we get stuff converted, but it
(strictly) isn't going to affect module writers too badly.

>...
> BTW, I am +1 with the conversion script, because the warnings are worth
> the change, I just want to make it an easy move for module authors.

This would be quite nice ... even better. I like the change with or without
the converter. Feel free :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message