httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/main http_log.c
Date Mon, 12 Jun 2000 19:57:39 GMT
On Mon, Jun 12, 2000 at 03:52:02PM -0400, Jeff Trawick wrote:
>... discussion re: umask-like change ...

Agreed.

>...
> On further thought, I don't think we need APR_PERM_ABSOLUTE.  As far
> as security goes, we just have to make sure that we don't end up with
> a file with looser permissions than we specify (not a problem on any
> known system).  
> 
> When the umask code was added some months back, I think a simpler
> change would have been to specify APR_UREAD | APR_UWRITE | APR_GREAD |
> APR_WREAD instead of APR_OS_DEFAULT.  If on Unix the umask of the
> process turns off any of those bits, so be it.
> 
> My change would be to back out your change, back out the old umask
> change (revision 1.27), and then specify APR_UREAD | APR_UWRITE |
> APR_GREAD | APR_WREAD instead of APR_OS_DEFAULT.  That cleans up that
> piece of code and punts on the umask issue until we have to figure out
> what will make sense cross-platform (hopefully never).
> 
> O.k.?

Sounds like the right approach.

+1


-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message