httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Life is hard, and then you die" <>
Subject Re: Filtered I/O ... again. :-)
Date Sat, 03 Jun 2000 10:44:37 GMT

On Wed, May 31, 2000 at 02:50:10PM -0700, Greg Stein wrote:
> On Wed, 31 May 2000 wrote:
> > > Correct. At the end of a request (defined how?), Apache needs to inform
> > > the filters to flush any internal buffers. This is the point where SSI
> > > could generate a syntax error for an unfinished tag.
> > 
> > Ahh, yep this does take care of the case I was thinking about, okay ignore
> > my last message and that potential improvement.
> :-)
> Note this applies to the hook-based design as well. Just pass a NULL
> buffer there, too.
> Oh. That is better than my first pass on this. In my proposal, I said a
> zero-length buffer. But I can easily see a mistake where zero-length is
> passed (ap_rwrite(buf, len, r) without testing "len"), thus making things
> believe they just hit EOF. Better is a NULL pointer for the buffer. Even
> if somebody passes len==0, I find it quite "impossible" for them to
> arrange a NULL buffer pointer. If they do... TFB for them. That is like
> expecting ap_rwrite(NULL, 0, r) to "work". Negative!

Overloading ap_rwrite() will work, but I feel adding ap_rclose() would be
cleaner/more natural.



View raw message