httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Life is hard, and then you die" <ron...@innovation.ch>
Subject Re: cvs commit: apache-2.0/src/modules/standard mod_auth_digest.c
Date Fri, 02 Jun 2000 12:30:05 GMT

On Thu, Jun 01, 2000 at 03:18:54PM -0700, Greg Stein wrote:
> On Thu, 1 Jun 2000 rbb@covalent.net wrote:
> > 
> > How do you feel about having MPMs which don't need shared memory
> > re-implementing ap_shm_* with malloc/free?
> 
> Icky.
> 
> The problem is when somebody goes to read the code. They will see ap_shm_
> calls in there, and get thrown off on what is really happening.
> 
> The MPM is, more than likely, going to need to make changes other than a
> simple malloc/free substitution. I'd rather see the SHM (or not) decision
> grouped up within the MPM, rather than stub some with ap_shm_* plus some
> other bits.  Kind of hard to explain here... :-)

The MPM's should be exporting mpm_shm_*, not overridding ap_shm_*.


  Cheers,

  Ronald


Mime
View raw message