httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <stodd...@raleigh.ibm.com>
Subject Re: cvs commit: apache-2.0/src/main http_log.c
Date Tue, 20 Jun 2000 20:44:49 GMT
I looked at it and ran away.

The write() call automagically adds a CR to files opened for text i/o. This is evil black
magic as far as I am concerned. WriteFile (used in ap_write) does not add the CR. The
obvious (and wrong) way to 'fix' this is to have ap_write scan lines for files opened for
i/o to non-binary files and add a CR or to add the CR in Apache before the call to
ap_write. Both of these 'solutions' are off the top of the suckage quotient scale. There
has to be a better way... Perhaps 'Just say no to notepad' :-)

Bill
----- Original Message -----
From: William A. Rowe, Jr. <wrowe@lnd.com>
To: <new-httpd@apache.org>
Sent: Tuesday, June 20, 2000 4:10 PM
Subject: RE: cvs commit: apache-2.0/src/main http_log.c


> > From: trawick@locus.apache.org [mailto:trawick@locus.apache.org]
> > Sent: Tuesday, June 20, 2000 2:37 PM
> > To: apache-2.0-cvs@apache.org
> > Subject: cvs commit: apache-2.0/src/main http_log.c
> >
> > trawick     00/06/20 12:36:54
> >
> >   Modified:    src      CHANGES
> >                src/lib/apr/file_io/os2 pipe.c
> >                src/lib/apr/file_io/unix filedup.c fileio.h
> > open.c pipe.c
> >                src/lib/apr/include apr_file_io.h
> >                src/lib/apr/threadproc/beos proc.c
> >                src/lib/apr/threadproc/os2 proc.c
> >                src/lib/apr/threadproc/unix proc.c
> >                src/lib/apr/threadproc/win32 proc.c
> >                src/main http_log.c
> >   Log:
> [...]
> >
> >   Win32:
> >
> >   The pipe was always created blocking before; no change
> >
> >   previously, ap_setprocattr_io() ignored the blocking flag; now it
> >   respects it like other platforms and calls ap_set_pipe_timeout(p,0)
> >   on appropriate pipe handles (Bill Stoddard was just working in
> >   ap_set_pipe_timeout(), so I presume this is golden)
>
> Before I throw something more on my plate, has anyone even looked at
> the missing cr bug in Win32 logs, i.e. all logged output is in <lf>
> rather than <cr><lf> format?


Mime
View raw message