httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Reid" <dr...@jetnet.co.uk>
Subject Re: cvs commit: apache-2.0/src/lib/apr/include apr_pools.h
Date Sat, 17 Jun 2000 21:46:19 GMT
Hmm, the main reasons I removed the calls to ap_pool_join from the modules
were
1) I couldn't see why they were there (dean pointed out why so this is
bogus)
2) I couldn't decide this very question

I actually think we should have them in the code ONLY if we're debugging.
Guess that should work OK and the calls can be converted to use the correct
number of args.  I'll add it to my list of stuff to do next week...

david

----- Original Message -----
From: "Greg Stein" <gstein@lyra.org>
To: <new-httpd@apache.org>
Sent: Saturday, June 17, 2000 10:10 PM
Subject: Re: cvs commit: apache-2.0/src/lib/apr/include apr_pools.h


> On Sat, Jun 17, 2000 at 04:33:08PM -0000, ben@locus.apache.org wrote:
> > ben         00/06/17 09:33:08
> >
> >   Modified:    src/lib/apr/include apr_pools.h
> >   Log:
> >   Remove duplicate definition.
> >
> >   Revision  Changes    Path
> >   1.18      +0 -1      apache-2.0/src/lib/apr/include/apr_pools.h
> >
> >   Index: apr_pools.h
> >   ===================================================================
> >   RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr_pools.h,v
> >   retrieving revision 1.17
> >   retrieving revision 1.18
> >   diff -u -r1.17 -r1.18
> >   --- apr_pools.h 2000/06/17 11:51:36 1.17
> >   +++ apr_pools.h 2000/06/17 16:33:08 1.18
> >   @@ -100,7 +100,6 @@
> >     */
> >    #ifndef POOL_DEBUG
> >    APR_EXPORT(ap_pool_t *) ap_find_pool(const void *ts);
> >   -#define ap_pool_join (a,b)
> >    #else
> >    APR_EXPORT(int) ap_pool_join(ap_pool_t *p, ap_pool_t *sub, int
(apr_abort)(int retcode));
> >    APR_EXPORT(ap_pool_t *) ap_find_pool(const void *ts, int
(apr_abort)(int retcode));
>
> That isn't a duplicate definition -- it is in the other side of the
#if/else
> block.
>
> Note also, that the old macro was incorrect -- not enough args and the
space
> meant that it didn't even take arguments :-)
>
> Not sure what the right answer here is. Maybe the function shouldn't exist
> outside of POOL_DEBUG?
>
> Hmm... should ap_find_pool exist outside? Given the different parameters,
I
> can't see how a person would use it in the code without an explicit
> POOL_DEBUG check.
>
> David: you've just gone through all this. What is the right answer here?
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
>


Mime
View raw message