httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@lnd.com>
Subject RE: [PATCH] RE: cvs commit: apache-1.3/src/os/win32 service.c service.h
Date Tue, 06 Jun 2000 12:27:33 GMT
> From: Andrew Braund [mailto:abraund_news@mail.com]
> Sent: Tuesday, June 06, 2000 12:16 AM
> 
> 
> This is my first attempt at a patch so please be gentle! I thought I would
> start with some changes to win_compiling.html. The changes mainly cater for the
> novice user. I have just seen a new version (apache-1.3_20000606041200.tar.gz)
> so will download it and start testing the new service stuff on 95 and add
> something to the windows.html documentation.

Good changes (perhaps C:\ServerRoot, to be consistent though?  I can see a
truly novice user retaining the D:, while they have no D: drive :-)  

> I downloaded apache-1.3_20000605221200.tar.gz then compiled (command line
> style) following instructions in windows.html and win_compiling.html. This went
> very well, a new user would get a good first impression.

Good to hear it!
 
> Other Comments;
> Makefile.win is a Windows (only) make file so why can't it copy the
> conf\*.conf-dist-win, conf\mime.types, conf\magic and htdocs\*.* files to the
> ServerRoot directory? Would this be a good thing/worth doing?

Hmmm.  Interesting, although often one is building the tree in the manner
it is distributed, that is src is the folder within the ServerRoot, and
the INSTDIR=.. - but this gives me an even more interesting idea; if the
httpd.conf is not found, and httpd.conf-dist-win is present, autogenerate
a proper httpd.conf on startup?

> PS; Many thanks to Mr William Rowe for all his effort on the 
> Windows code, and sorry for complaining :(.

Complaining?  I don't remember your name as a complainer, at least not once
you start submitting patches for the fixes you want to see :-)  


Mime
View raw message