Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Sat, 27 May 2000 18:08:59 -0700 (PDT)
From: rbb@covalent.net
To: new-httpd@apache.org
Subject: RE: cvs commit: apache-2.0/src/lib/apr/time/win32 timestr.c
In-Reply-To: <000f01bfc83f$18e503e0$345985d0@corecomm.net>
Message-ID: <Pine.LNX.4.21.0005271805320.9744-100000@koj.rkbloom.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


ARGH!!!!!!  This is way too confusing.  This is confusing because that one
patch had a lot of very un-related changes in it.  Here's the bottom line
for me.  After you backed out all the changes, the code didn't compile on
Unix.  I made three name changes, and it compiled again.

Now, if you want to make a name change for these types of Macros then we
should discuss it here and come to a consensus on the correct names, and
then implement it in one patch for each name change.

I'll comment on name changes in response to another note.

Ryan


On Sat, 27 May 2000, William A. Rowe, Jr. wrote:

> Contrawise, they were the ones I'd already caught :-)
> 
> It's APR_EXPORT_VAR -> APR_VAR_EXPORT, as we are backing out
> that change to the core (API_, CORE_, and MODULES_) we need
> to be consistent.
> 
> Actually, that was my (unfortunately not obvious enough) clue
> that the patch on Fri eve. was forthcoming.  I think I even
> posted to that effect.
> 
> If we want _VAR_EXPORT -> _EXPORT_VAR, see my post.  But there
> is no way APR is playing it's own game to this point.
> 
> Bill
> 
> > -----Original Message-----
> > From: rbb@covalent.net [mailto:rbb@covalent.net]
> > Sent: Saturday, May 27, 2000 7:45 PM
> > To: new-httpd@apache.org
> > Subject: Re: cvs commit: apache-2.0/src/lib/apr/time/win32 timestr.c
> > 
> > 
> > On Sat, 27 May 2000, Greg Stein wrote:
> > 
> > > Euh... OtherBill just backed out that rename... :-)
> > 
> > These are the ones he missed.
> > 
> > Ryan
> > 
> > ______________________________________________________________
> > _________________
> > Ryan Bloom                        	rbb@apache.org
> > 406 29th St.
> > San Francisco, CA 94131
> > --------------------------------------------------------------
> > -----------------
> > 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------