Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 60731 invoked by uid 500); 20 May 2000 03:20:54 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk X-No-Archive: yes Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 60719 invoked from network); 20 May 2000 03:20:53 -0000 Date: Fri, 19 May 2000 20:20:53 -0700 (PDT) From: Ask Bjoern Hansen To: new-httpd@apache.org Subject: Re: cvs commit: apache-2.0/src/support ab.c In-Reply-To: <20000519021807.9224.qmail@locus.apache.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N On 19 May 2000 trawick@locus.apache.org wrote: > Log: > ab: Fix a command-line processing bug; track bad headers in > err_response; support reading headers up to 2K. (In the > original patch it was 8K instead of 2K; it isn't clear to me > that 8K is really needed or appropriate.) > Submitted by: Ask Bjoern Hansen > Reviewed by: Jeff Trawick Hmn. it would be helpful if it gave a clue about what was going on since it strictly speaking is ab messing up the headers. Not that it's likely, but a bunch of cookies could make the headers >2K. - ask Index: ab.c =================================================================== RCS file: /home/cvspublic/apache-2.0/src/support/ab.c,v retrieving revision 1.16 diff -u -d -b -w -r1.16 ab.c --- ab.c 2000/05/19 22:39:40 1.16 +++ ab.c 2000/05/20 03:14:00 @@ -490,7 +490,8 @@ ap_close_socket(c->aprsock); err_conn++; if (bad++ > 10) { - err("\nTest aborted after 10 failures\n\n"); + err("\nTest aborted after 10 failures. Increase verbosity " + "with -v 1-4 to get a hint about what is going on.\n\n"); } start_connect(c); } @@ -607,8 +608,13 @@ ap_remove_poll_socket(readbits, c->aprsock); ap_close_socket(c->aprsock); err_response++; + if (verbosity >= 1) + printf("WARNING: invalid http header. Likely because it's " + "bigger than %i bytes. This limit can be changed in " + "ab.c\n", CBUFFSIZE); if (bad++ > 10) { - err("\nTest aborted after 10 failures\n\n"); + err("\nTest aborted after 10 failures. Increase verbosity " + "with -v 1-4 to get a hint about what is going on.\n\n"); } start_connect(c); } -- ask bjoern hansen - more than 70M impressions per day,