Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Sun, 28 May 2000 08:32:11 -0400
Message-Id: <200005281232.IAA01112@k5.localdomain>
From: Jeff Trawick <trawickj@bellsouth.net>
To: new-httpd@apache.org
In-reply-to: <392E9BF9.6169F553@raleigh.ibm.com> (message from Greg Ames on
	Fri, 26 May 2000 11:44:57 -0400)
Subject: Re: cvs commit: apache-2.0/src/include util_charset.h
Reply-to: trawickj@bellsouth.net
References: <20000525205125.73048.qmail@locus.apache.org>
 <392E9BF9.6169F553@raleigh.ibm.com>

> Date: Fri, 26 May 2000 11:44:57 -0400
> From: Greg Ames <gregames@raleigh.ibm.com>
> X-Accept-Language: en
> Content-Type: text/plain; charset=us-ascii
> X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N
> X-UIDL: 545966f7fe61178c254dfd729ce189e4
> 
> Per our discussion, it sounds like a Good Thing to change the xlat
> design so that ap_checkconv() doesn't have to be called from every
> handler that might send binary content.  That way we don't have to worry
> about mod_php, mod_perl, etc..
> This could be done by moving the ap_checkconv() call out of the handlers
> and into ap_send_http_header, then taking care of any weird cases that
> break (like MD5) outside of the handlers also.   
> 
> Greg Ames

Absolutely.  In the short term, we'll go from three calls to
ap_checkconv() to two (the normal one in ap_send_http_header() plus
the unfortunate one prior to MD5 generation), but in the long term we
may still have just those two calls and yet more modules will work
without tweaking for EBCDIC.

It is too bad that 1.3 didn't do it the way you suggest.  If so, we
could have avoided the recent change to 1.3's mod_mmap_static.  As it
is, handlers which can generate binary content are completely broken
on EBCDIC if there is no call to ap_checkconv() in the path.  I'll do
your cleanup for 2.0 Real Soon Now.

> trawick@locus.apache.org wrote:
> 
> >   Index: util_ebcdic.c
> >   ===================================================================
> >   RCS file: /home/cvs/apache-2.0/src/main/util_ebcdic.c,v
> 
> >   @@ -184,13 +144,10 @@
> [...]
> >   +    /* Turn off conversion if it's a text document */
> 
> Oooops - I think you meant:
>          /* Turn off conversion if it's not a text document */
> The code looks right.
> 
> >   +    if (!convert_to_ascii) {
> >   +        ap_set_content_xlate(r, 1, zero);
> >        }
> 

yep; done

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...