Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Mon, 8 May 2000 09:56:48 -0400
Message-Id: <200005081356.JAA08327@k5.localdomain>
From: Jeff Trawick <trawickj@bellsouth.net>
To: new-httpd@apache.org
In-reply-to: <200005081326.HAA09826@sanitas> (pg@sweng.stortek.com)
Subject: Re: ???src/main/util_ebcdic.c and src/include/util_ebcdic.h???
Reply-to: trawickj@bellsouth.net
References: <200005081326.HAA09826@sanitas>

> In a recent note, Jeff Trawick said:
> 
> > Date: Sun, 7 May 2000 22:25:34 -0400
> > 
> > It should be o.k. for non-EBCDIC platforms to include and compile them as
> > long as they collapse to nothing, right?
> > 
> Alternatively, the #include could be wrapped with #ifdef EBCDIC.  Minor
> compile time performance consideration.
> 
> -- gil
> -- 
> StorageTek
> INFORMATION made POWERFUL

Yes, that is how it is today.

At the moment, I think it is worthwhile to consider increasing build
times by a very small amount in return for avoiding #ifdefs, so at the
moment I'm more interested in seeing how much negative feedback I get.
Your response would seem to go in that category :)

Alternatively, maybe this is more palatable to everybody if it is
layered as follows:

Blindly include "util_charset.h" where appropriate.

inside util_charset.h:

#ifdef APACHE_XLATE

#ifdef CHARSET_EBCDIC
#include "util_ebcdic.h"
#endif

(future stuff applicable to charset handling in general other than
stuff that would live in a module like mod_ebcdic or mod_charset)

#endif /* APACHE_XLATE */

At the current time, APACHE_XLATE isn't defined and there is no
util_charset.h (or even util_ebcdic.c or util_ebcdic.h) but those are
minor details which are easily corrected.

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...