httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: [PATCH] improving line number reporting for config file syntax errors
Date Mon, 29 May 2000 22:21:26 GMT

> The basic idea of my patch is that we pass back a ptr to the
> ap_directive_t where we noticed the problem.  I don't know what we'd
> ever need besides file+line number, but it is convenient as-is and may
> be useful in the future.
> I like your patch for the brevity, but I get bad vibes from the way
> the info is passed back.  Right now, I get bad vibes from my patch
> because of the amount of changes required (albeit simple changes) but
> I like the way the information is passed back.

That is the problem I also have with my patch, and what I like about your
patch.  Does this current patch actually report the corrent line number in
all cases?  I'll apply/test your patch later today.

> Note: My patch does not pass the address of the bad ap_directive_t to
> the caller of ap_build_cont_config().  I don't think such detail is
> reported from there anyway. 

It should be reported from there.

> Note also that the externalized routine ap_limit_section() has an
> additional parameter.  Comments state that it is externalized for
> mod_perl.

Hmmm.  I would really like to understand that.

>      TAKE123,			/* one, two or three arguments */
> -    TAKE13			/* one or three arguments */
> +    TAKE13,			/* one or three arguments */
> +    RAW_ARGS_D                  /* like RAW_ARGS, but with ap_directive_t */
>  };

I thought we were trying to get rid of RAW_ARGS, adding another RAW_ARGS
type is a bad idea IMO.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message