httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject RE: cvs commit: apache-2.0/src/lib/apr/misc/unix errorcodes.c
Date Mon, 29 May 2000 04:24:01 GMT
> >    static char *apr_error_string(ap_status_t statcode)
> >    {
> >   +    char buf[256];
> 
> >        case APR_EDSOOPEN:
> > >   -        return ap_dso_error();
> > >   +        return ap_dso_error(buf, sizeof(buf), APR_EDSOOPEN);
> > > 
> > > If you mean to allow the ap_dso_error call to return it's result
> > > in buf, we just off the result from the stack frame :-)
> > 
> > buf will work just fine if the OS requires buf.  If not, we 
> > ignore it.  In
> > the case of Unix, we don't need the buff.  On other platforms 
> > we may need
> > it.
> > 
> > This patch should work just fine.  But, I really don't care anymore.
> 
> If we need the buf for the error message, we just allocated it on
> the stack, and then we blew off our stack as we return the error.
> That's what I ment.  I wasn't aware Unix didn't use it.

As far as I can tell, nobody needs this variable, but this is the fix that
people seemed to want.  :-)

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message