httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject RE: cvs commit: apache-2.0/src/main iol_file.c
Date Fri, 26 May 2000 19:55:56 GMT

This patch is wrong, and it breaks saferead on Win32.  A patch that you
aren't sure about should probably not be committed until it has been
posted on new-httpd.  IMHO.

Ryan

On Sat, 27 May 2000, William A. Rowe, Jr. wrote:

> > wrowe       00/05/27 00:06:28
> > 
> >   Modified:    src/main iol_file.c
> >   Log:
> >     A workaround since we haven't implemented the will_block 
> > stuff in Win32.
> >   
> >   Revision  Changes    Path
> >   1.18      +4 -0      apache-2.0/src/main/iol_file.c
> >   
> >   Index: iol_file.c
> >   ===================================================================
> >   RCS file: /home/cvs/apache-2.0/src/main/iol_file.c,v
> >   retrieving revision 1.17
> >   retrieving revision 1.18
> >   diff -u -r1.17 -r1.18
> >   --- iol_file.c	2000/05/24 22:27:16	1.17
> >   +++ iol_file.c	2000/05/27 07:06:27	1.18
> >   @@ -138,7 +138,11 @@
> >        file_getopt,
> >        NULL,
> >        NULL,
> >   +#ifdef WIN32
> >   +    NULL
> >   +#else
> >        file_check_read
> >   +#endif
> >    };
> >    
> >    /*
> 
> That's it for tonight... I'm not 100% on this patch, so I thought I would
> point it out if someone else wants to take a look at a better solution.
> 
> Win32 is building everything from the libraries through the modules.  The
> support/ exe's need more work, and I will attack those tommorow.
> 
> 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message