httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject RE: Platform Specific APR Design Questions
Date Fri, 19 May 2000 20:10:29 GMT

I have to agree completely with Greg on this one.  Just because a function
uses APR pools, does not make it a candidate for APR.  This is Windows
code, plain and simple.  I also don't see how this code could be used for
any project other than Apache.

Ryan

On Fri, 19 May 2000, Greg Stein wrote:

> IMO, the registry stuff does not go into APR. There is no portable
> equivalent, meaning they are Win32 specific. They should stay in
> os/win32/registry.c
> 
> Cheers,
> -g
> 
> On Fri, 19 May 2000, William A. Rowe, Jr. wrote:
> 
> > Ok, Ryan, here's something I need guidance in...
> > 
> > os/win32/registry.c was a hack to store info in the registry.  
> > It contained about 2 too many levels of abstraction, so I've 
> > chopped it down quite a bit and moved specific keys into
> > the os/win32/service.c module.  
> > 
> > The crux of the module are the following functions:
> > 
> > extern ap_status_t ap_registry_get_value(ap_pool_t *p, char *key, char *name, char
**ppValue);
> > extern ap_status_t ap_registry_store_value(char *key, char *name, void *value);
> > extern ap_status_t ap_registry_delete_value(char *key, char *name);
> > extern ap_status_t ap_registry_delete_key(char *key);
> > 
> > Key creation is implicit.  A pool is preallocated to handle
> > the creation of the returned value.
> > 
> > Is this appropriate for APR?  It certainly isn't a functionally
> > abstract unit, but does apply APR (pool storage) to a specific
> > platform.  There is really no equivilant on other platforms,
> > and the usage would be entirely different (for that matter,
> > it's entirely different between NT and 9x :-)
> > 
> > Let me know and I'll slide it to lib/apr/misc, if you deem this
> > the right solution.
> > 
> > Bill
> > 
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message