httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/lib/apr/include apr.h.in
Date Tue, 02 May 2000 00:42:21 GMT
On 2 May 2000 sascha@locus.apache.org wrote:

> sascha      00/05/01 20:01:03
> 
>   Modified:    src/lib/apr acconfig.h configure.in
>                src/lib/apr/include apr.h.in
>   Log:
>   Substitute sigthreadmask for pthread_sigmask, if necessary.
>   
>   Note that the behaviour of sigprocmask in a multi-threaded program is
>   undefined. The AIX 4.3 documentation explicitly says "The
>   sigprocmask, sigsetmask, and sigblock subroutines must not be used in
>   a multi-threaded application."
>   
>   This change allows us to build the Dexter and mpmt_pthread MPM on AIX.

This needs to be backed out.  The change is not namespace safe.  I haven't
looked at this yet, but I'll try to get to it tomorrow.  This change also
can't work, because the file that defines HAVE_PTHREAD_SIGMASK and
HAVE_SIGTHREADMASK (apr_private.h), is a private file, and cannot be
included by any public header file.

Ryan

>   Index: apr.h.in
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/include/apr.h.in,v
>   retrieving revision 1.20
>   retrieving revision 1.21
>   diff -u -u -r1.20 -r1.21
>   --- apr.h.in	2000/05/01 21:22:45	1.20
>   +++ apr.h.in	2000/05/02 03:01:02	1.21
>   @@ -117,4 +117,9 @@
>    #define ap_signal(a,b) signal(a,b)
>    #endif
>    
>   +#if !defined(HAVE_PTHREAD_SIGMASK) && defined(HAVE_SIGTHREADMASK)
>   +#define pthread_sigmask sigthreadmask
>   +#define HAVE_PTHREAD_SIGMASK 1
>   +#endif
>   +
>    #endif /* APR_H */
>   
>   
>   
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message