httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <grega...@raleigh.ibm.com>
Subject Re: cvs commit: apache-2.0/src/include util_charset.h
Date Fri, 26 May 2000 15:44:57 GMT
Per our discussion, it sounds like a Good Thing to change the xlat
design so that ap_checkconv() doesn't have to be called from every
handler that might send binary content.  That way we don't have to worry
about mod_php, mod_perl, etc..
This could be done by moving the ap_checkconv() call out of the handlers
and into ap_send_http_header, then taking care of any weird cases that
break (like MD5) outside of the handlers also.   

Greg Ames

trawick@locus.apache.org wrote:

>   Index: util_ebcdic.c
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/main/util_ebcdic.c,v

>   @@ -184,13 +144,10 @@
[...]
>   -    }
>   -    /* Enable conversion if it's a text document */
>   -    if (convert_to_ascii) {
>   -        ap_bsetopt(r->connection->client, BO_WXLATE, &ap_locale_to_ascii);
>        }
>   -    else {
>   -        ap_bsetopt(r->connection->client, BO_WXLATE, &zero);
>   +    /* Turn off conversion if it's a text document */

Oooops - I think you meant:
         /* Turn off conversion if it's not a text document */
The code looks right.

>   +    if (!convert_to_ascii) {
>   +        ap_set_content_xlate(r, 1, zero);
>        }

Mime
View raw message